/SL/IR.pm - Diff - projekt kivitendo - wissen

« Zurück | Weiter »

Revision ba6a1366

Verbesserung Lesbarkeit von Code

Dieser Commit verbessert noch an Stellen, die Währungen betreffen,
die Lesbarkeit des Codes.

              v.id AS vendor_id, v.name AS vendor, v.discount as vendor_discount,
              v.creditlimit, v.terms, v.notes AS intnotes,
              v.email, v.cc, v.bcc, v.language_id, v.payment_id,
              v.street, v.zipcode, v.city, v.country, v.taxzone_id, (SELECT cu.name FROM currencies cu WHERE cu.id=v.currency_id) AS curr, v.direct_debit,
              v.street, v.zipcode, v.city, v.country, v.taxzone_id, cu.name AS curr, v.direct_debit,
              $duedate + COALESCE(pt.terms_netto, 0) AS duedate,
              b.description AS business
            FROM vendor v
            LEFT JOIN business b       ON (b.id = v.business_id)
            LEFT JOIN payment_terms pt ON (v.payment_id = pt.id)
            LEFT JOIN currencies cu    ON (v.currency_id = cu.id)
            WHERE 1=1 $where|;
       my $ref = selectfirst_hashref_query($form, $dbh, $query, @values);
       map { $params->{$_} = $ref->{$_} } keys %$ref;
-...
       # fax and phone and email as vendor*
       my $query =
         qq|SELECT ct.*, cp.*, ct.notes as vendornotes, phone as vendorphone, fax as vendorfax, email as vendoremail,
              (SELECT cu.name FROM currencies cu WHERE cu.id=ct.currency_id) AS currency
              cu.name AS currency
            FROM vendor ct
            LEFT JOIN contacts cp ON (ct.id = cp.cp_cv_id)
            LEFT JOIN currencies cu ON (ct.currency_id = cu.id)
            WHERE (ct.id = ?) $contact
            ORDER BY cp.cp_id
            LIMIT 1|;

Auch abrufbar als: Unified diff