Projekt

Allgemein

Profil

« Zurück | Weiter » 

Revision 0c32dd23

Von Moritz Bunkus vor mehr als 14 Jahren hinzugefügt

  • ID 0c32dd23e6c2d104239bd489fc61b81db8f19f59
  • Vorgänger 1e0d4130
  • Nachfolger 6b9cf44d

Bei Auth-DB-Verbindung nur Transaktionen starten, wenn tatsächlich Dinge verändert werden; dann explizit locken

Fix für Bug 1565.

Unterschiede anzeigen:

SL/Auth.pm
$main::lxdebug->message(LXDebug->DEBUG1, "Auth::dbconnect DSN: $dsn");
$self->{dbh} = DBI->connect($dsn, $cfg->{user}, $cfg->{password}, { pg_enable_utf8 => $::locale->is_utf8, AutoCommit => 0 });
$self->{dbh} = DBI->connect($dsn, $cfg->{user}, $cfg->{password}, { pg_enable_utf8 => $::locale->is_utf8, AutoCommit => 1 });
if (!$may_fail && !$self->{dbh}) {
$main::form->error($main::locale->text('The connection to the authentication database failed:') . "\n" . $DBI::errstr);
......
my ($sth, $query, $user_id);
$dbh->begin_work;
$query = qq|SELECT id FROM auth."user" WHERE login = ?|;
($user_id) = selectrow_query($form, $dbh, $query, $login);
......
my $form = $main::form;
my $dbh = $self->dbconnect();
$dbh->begin_work;
my $query = qq|SELECT id FROM auth."user" WHERE login = ?|;
my ($id) = selectrow_query($form, $dbh, $query, $login);
return $main::lxdebug->leave_sub() if (!$id);
$dbh->rollback and return $main::lxdebug->leave_sub() if (!$id);
do_query($form, $dbh, qq|DELETE FROM auth.user_group WHERE user_id = ?|, $id);
do_query($form, $dbh, qq|DELETE FROM auth.user_config WHERE user_id = ?|, $id);
......
if ($session_id) {
my $dbh = $self->dbconnect();
$dbh->begin_work;
do_query($main::form, $dbh, qq|DELETE FROM auth.session_content WHERE session_id = ?|, $session_id);
do_query($main::form, $dbh, qq|DELETE FROM auth.session WHERE id = ?|, $session_id);
......
my $self = shift;
my $dbh = $self->dbconnect();
$dbh->begin_work;
my $query =
qq|DELETE FROM auth.session_content
WHERE session_id IN
......
$form = $main::form;
$dbh = $self->dbconnect();
$dbh->begin_work;
do_query($::form, $dbh, qq|LOCK auth.session_content|);
$query = qq|SELECT id FROM auth.session WHERE id = ?|;
($id) = selectrow_query($form, $dbh, $query, $session_id);
......
my $dbh = $provided_dbh || $self->dbconnect();
$dbh->begin_work unless $provided_dbh;
do_query($::form, $dbh, qq|LOCK auth.session_content|);
do_query($::form, $dbh, qq|DELETE FROM auth.session_content WHERE session_id = ?|, $session_id);
if (%{ $self->{SESSION} }) {
......
my $form = $main::form;
my $dbh = $self->dbconnect();
$dbh->begin_work;
my ($query, $sth, $row, $rights);
if (!$group->{id}) {
......
my $form = $main::from;
my $dbh = $self->dbconnect();
$dbh->begin_work;
do_query($form, $dbh, qq|DELETE FROM auth.user_group WHERE group_id = ?|, $id);
do_query($form, $dbh, qq|DELETE FROM auth.group_rights WHERE group_id = ?|, $id);

Auch abrufbar als: Unified diff